Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint consistent type import #3247

Closed
wants to merge 7 commits into from
Closed

Conversation

flvndvd
Copy link
Contributor

@flvndvd flvndvd commented Jan 16, 2024

The recent incidents where we've imported types from Sequelize into files subsequently used in the front end have caused Dust to fail to load. One way to mitigate this is by utilizing import type, which ensures type imports are stripped out at runtime. This PR introduces a rule enforcing this practice and corrects all the associated errors until we find a more robust linter rule.

Copy link

github-actions bot commented Jan 16, 2024

Fails
🚫

Files in front/lib/models/ or connectors/src/lib/models/ have been modified. Please add the migration-ack label to acknowledge that a migration will be needed once merged into 'main'.

Generated by 🚫 dangerJS against 4020c66

@flvndvd flvndvd requested a review from fontanierh January 17, 2024 08:27
@flvndvd
Copy link
Contributor Author

flvndvd commented Jan 17, 2024

Closing in favor of #3248.

@flvndvd flvndvd closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant